Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pod details page to new design. #968

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Update pod details page to new design. #968

merged 1 commit into from
Apr 9, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Apr 9, 2020 •
edited
Loading

Done

  • Changed label for power address if pod is a LXD host (Virsh => LXD URL)
  • Fixed copy to clipboard for power address
  • Removed speed input from compose form
  • Removed "Minimum" from cores and RAM labels in compose form

QA

  • Check that the details page matches the design
  • Check that the compose form matches the design
  • Check that you can still compose machines

Fixes

Fixes canonical-web-and-design/MAAS-squad#1877
Fixes #686

anthonydillon
anthonydillon approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anthonydillon anthonydillon merged commit c1fc422 into canonical:master Apr 9, 2020
@Caleb-Ellis Caleb-Ellis deleted the kvm-details-updates branch October 28, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydillon anthonydillon anthonydillon approved these changes

Assignees

@anthonydillon anthonydillon

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy to clipboard erroring
2 participants
@Caleb-Ellis @anthonydillon