Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add waitForPageToLoad cypress command #3673

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 11, 2022

Done

  • add waitForPageToLoad cypress command
    • use more reliable cypress queries for detecting appearance/disappearance

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • Steps for QA.

Fixes

Fixes canonical-web-and-design/app-tribe#756

Launchpad issue

Related Launchpad maas issue in the form lp#number.

Backports

In general, please propose fixes against master rather than release branches (e.g. 2.7), unless the fix is only applicable for that specific release. Please apply backport labels to the PR (e.g. "Backport 2.7") for the appropriate releases to target.

Only bug and security fixes should be backported, new features should only land in master.

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@petermakowski petermakowski merged commit 6475da9 into canonical:master Mar 15, 2022
@petermakowski petermakowski deleted the add-waitForPageToLoad-cypress-util branch May 9, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants