Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): reserved ranges layout #3613

Merged

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Feb 10, 2022

Done

  • update reserved ranges layout
    • update edit form layout to fin in a row
    • update label to “comment” to be consistent with the API
    • fix table widths using flex (width was ignored)
    • edit form displays in a single column (current limitation of the MainTable component)

Screenshots

before

Pasted Graphic 6

after

Pasted Graphic 5

before

Reserved ranges

after

Reserved ranges
START IP ADDRESS

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • Go to a subnet view with reserved ranges
  • verify reserved ranges table is displayed correctly

Fixes

Fixes: # .

Launchpad issue

Related Launchpad maas issue in the form lp#number.

Backports

In general, please propose fixes against master rather than release branches (e.g. 2.7), unless the fix is only applicable for that specific release. Please apply backport labels to the PR (e.g. "Backport 2.7") for the appropriate releases to target.

Only bug and security fixes should be backported, new features should only land in master.

Comment on lines +3 to +5
td {
white-space: normal;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to allow text wrapping in the responsive table variant.

@petermakowski petermakowski changed the title update reserved ranges layout fix(ui): reserved ranges layout Feb 10, 2022
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@petermakowski petermakowski merged commit 756a570 into canonical:master Feb 10, 2022
@petermakowski petermakowski deleted the update-reserved-ranges-layout branch May 9, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants