Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the message when the websocket closes #1253

Merged
merged 5 commits into from
Jun 16, 2020
Merged

Fix the message when the websocket closes #1253

merged 5 commits into from
Jun 16, 2020

Conversation

huwshimi
Copy link
Contributor

Done

  • Correctly get the url when the websocket disconnects.

QA

  • Visit a legacy url.
  • Stop your maas websocket.
  • In your console you should see a warning like: WebSocket connection closed: ws://dev.local:8400/MAAS/ws

Fixes

Fixes: #1252.

@huwshimi huwshimi merged commit 53b5c66 into canonical:master Jun 16, 2020
@huwshimi huwshimi mentioned this pull request Jun 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees

@squidsoup squidsoup

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

url.split error when legacy ws disconnects
2 participants
@huwshimi @squidsoup