Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit bond form not saving all values. #1247

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Fix edit bond form not saving all values. #1247

merged 3 commits into from
Jun 12, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Jun 12, 2020 •
edited
Loading

Done

  • Fixed edit bond form not saving some values correctly.
  • Driveby fix for disconnected icon on "Create bond" form

QA

  • Go to the network details of a New machine and create a bond by combining two interfaces on the same VLAN. Make sure to change the bond mode, hash policy, LACP rate and link monitoring.
  • Check that the bond is created successfully, then open the edit bond form.
  • Change the values for bond mode, hash policy, LACP rate and link monitoring and save
  • Reopen the edit bond form and check that the values were saved correctly.

Fixes

Fixes #1193

@Caleb-Ellis Caleb-Ellis merged commit f0c3e79 into canonical:master Jun 12, 2020
@Caleb-Ellis Caleb-Ellis deleted the fix-bond-save branch June 12, 2020 07:58
Caleb-Ellis pushed a commit that referenced this pull request Jun 12, 2020
Fix edit bond form not saving all values. (#1247)
1ea774c
Caleb-Ellis pushed a commit that referenced this pull request Jun 12, 2020
Fix edit bond form not saving all values. (#1247)
c165eef
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network / Create bond issue
2 participants
@Caleb-Ellis @huwshimi