Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining relative links in react codebase. #1198

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Jun 3, 2020

Done

  • Fixed a couple of remaining relative links in the react codebase

QA

  • For each case check the link takes you to the right place and the page does not refresh:
    • Machine list > Machine FQDN should take you to /MAAS/l/machine/<system_id>,
    • Machine list > Machine MAC should take you to /MAAS/l/machine/<system_id>,
    • Machine list > Machine Zone should take you to /MAAS/l/zone/<zone_id>,
    • Machine list > Machine Fabric should take you to /MAAS/l/fabric/<fabric_id>,
    • Settings > DHCP snippets "Applies to" field of node snippets should take you to the right place

Fixes

Fixes #1197

Launchpad Issue

https://bugs.launchpad.net/maas/+bug/1881954

Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, found a few more!

@Caleb-Ellis Caleb-Ellis merged commit 8c59f1d into canonical:master Jun 4, 2020
@Caleb-Ellis Caleb-Ellis deleted the react-relative-links branch June 4, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI uses absolute URLs for machine entries
2 participants