Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DHCP status for DHCP relay (#1173) #1195

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

vtapia
Copy link
Contributor

@vtapia vtapia commented Jun 3, 2020

Done

  • Set DHCP status to "Relayed via ##" instead of "No DHCP" when DHCP is relayed, both in the node and the network pages

QA

In a machine with two fabrics (e.g. fabric-0 and fabric-1) with a different subnet each:

  • Enable DHCP in fabric-0's vlan page
  • Enable DHCP relay in fabric-1's vlan page
  • /MAAS/#/networks?by=fabric should show "Relayed via fabric-0.untagged" for fabric-1 instead of "No DHCP"
  • After deploying a machine with an interface on fabric-1, the machine should show "Relayed via fabric-0.untagged" instead of "No DHCP" in /MAAS/#/machine/$id

Fixes

Fixes #1173 .

Launchpad Issue

lp#1879979

Copy link
Contributor

@Caleb-Ellis Caleb-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for that @vtapia - I'll add a follow-up branch for the network tab in machine details, add tests and play around with the table widths so it's not so heavily truncated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI,feature] Subnets page should distinguish between DHCP and DHCP Relay
2 participants