Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issues from Vanilla class disordering. #1179

Merged
merged 4 commits into from
May 29, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Fixed styling issues occurring because of Vanilla classes being included in root and in the individual apps. This meant that Vanilla classes were out of their usual order, so some styles were being overwritten when they shouldn't have and vice versa. This PR should address all those issues, because now only placeholders and base classes are being included in the apps (except for u-baseline-grid)
  • Rewrote a few classes so they no longer include entire mixins or extend classes.
  • Replaced custom legacy .p-cta classes with Vanilla .p-contextual-menu. I think the component was built when Vanilla didn't have icons in buttons.
  • Removed .p-table-menu from legacy - it was only used in the old machine list which has now been replaced. It's not used in the machine list seen in the KVM details pages.
  • Updated the root loading template to look more like the react loading template.

QA

  • Check that the action menu in legacy and react pages look good.
  • Check that table sortable in legacy looks good (e.g. go to device list)
  • Check that machine details > events shows information icons correctly
  • Refresh and navigate between apps and check that the loading template doesn't jump around while the app is loading.

Fixes

Fixes #1172
Fixes #1174

@Caleb-Ellis Caleb-Ellis force-pushed the vanilla-ordering-fix branch from ba67b59 to c7cbb41 Compare May 29, 2020 02:17
@Caleb-Ellis Caleb-Ellis merged commit fff3fc4 into canonical:master May 29, 2020
@Caleb-Ellis Caleb-Ellis deleted the vanilla-ordering-fix branch May 29, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Take action menu has deteriorated with the last update. Broken CSS in take action dropdown
2 participants