Add hashroute redirect with machine listing fallthrough. #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidsoup
commented
May 28, 2020
| .state("podDetails", { | ||
| url: prefixRoute("/pod/:id"), | ||
| redirectTo: prefixRoute("/kvm/:id"), | ||
| }) |
There was a problem hiding this comment.
just reformatting here.
squidsoup
commented
May 28, 2020
| @@ -227,6 +233,26 @@ const configureRoutes = ($stateProvider, $urlRouterProvider) => { | |||
| template: dashboardTmpl, | |||
| controller: "DashboardController", | |||
| }); | |||
|
|
|||
| $urlRouterProvider.otherwise(($injector, $location) => { | |||
There was a problem hiding this comment.
unfortunately $rootScope isn't available in the angularjs config function, so I can't reuse caleb's nice navigation functions.
huwshimi
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Add redirect for legacy hash-based routes, with a fall through to the machine listing.
QA
/MAAS/#/controllers, you should be redirected to/MAAS/l/controllers./MAAS/l/foo, you should be redirected to the machine listing.