Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit interface form not being able to edit tags/speeds. #1063

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Apr 30, 2020

Done

  • Fixed some incorrect markup that was making the edit form unusable if the machine had a tag.
  • Fixed some incorrect logic that prevented link speeds and interface speeds to be updated in the dit interface form.

QA

  • Go to http://bolla.internal:5240/MAAS/#/machine/t4kwcq?area=network and try to edit the first interface. When you submit the form you should get an error about tags.
  • Try to edit the link and interface speeds on the second interface. The form should submit but the values should not be updated.
  • Pull this branch and attempt to do the same things on the same machine. Also try to add and remove tags. Everything should work.

Fixes

Fixes #852

Launchpad Issue

#1864241

@Caleb-Ellis Caleb-Ellis merged commit 3c9281e into canonical:master Apr 30, 2020
@Caleb-Ellis Caleb-Ellis deleted the edit-interface-fix branch April 30, 2020 04:22
Caleb-Ellis pushed a commit to Caleb-Ellis/maas-ui that referenced this pull request May 6, 2020
@Caleb-Ellis Caleb-Ellis mentioned this pull request May 6, 2020
Caleb-Ellis pushed a commit that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit physical interface in gui
2 participants