Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine chassis power types from api. #1040

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Determine chassis power types from api. #1040

merged 1 commit into from
Apr 27, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Replaced hardcoded list of chassis power types with dynamically filtered list from api.

QA

  • Go to /r/machines/add and check that all the power types can be selected from the dropdown.
  • Go to /r/machines/chassis/add and check that the list of power types is filtered by chassis: true according to general.powerTypes.data in state.

Fixes

Fixes #1012

@Caleb-Ellis Caleb-Ellis force-pushed the chassis-power-types branch from ee79fee to 0918f3d Compare April 27, 2020 03:23
@Caleb-Ellis Caleb-Ellis merged commit 0185583 into canonical:master Apr 27, 2020
@Caleb-Ellis Caleb-Ellis deleted the chassis-power-types branch April 27, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees
No one assigned
Labels
Review: Code +1 (with changes) Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chassis power types should be dynamically listed
2 participants
@Caleb-Ellis @huwshimi