ci, build: update CI, libraries, python dependencies, and format #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the CI with standard CI configuration (juju, actions, deps) that is shared across multiple repositories. All python dependencies are also updated to their latest working versions. This PR also includes library updates. Finally, some formatting was applied on non-compliant files (copyright, style).
Because some dependencies of jsonschema require the rust toolchain (see 1 and 2), building the charm fails when building and installing some deps of jsonschema. The workaround to this is to install jsonschema from binary, avoiding unnecesary toolchains in the charm and reducing the chance of getting affected by third party dependencies when they are updated. Other considerations: Other options were considered for fixing the issue, like installing rustc in the charm directly and pinning jsonschema<4.18. The first option seem too invasive as charms will not use rustc for anything during runtime. The last option restricted us from updating the package in the event of a bug fix or if a new version is needed. Installing from binary also has limitations, such as version management, which is now done in charmcraft.yaml and not in the more common requirement files. Fixes: #147 [1]python-jsonschema/jsonschema#1117 [2] python-jsonschema/jsonschema#1114
Fix assertion errors raised in unit tests caused by updating ops from 1.5 to 2+. Due to this change, we now have to take an extra step to enable container connectivity when not using `begin_with_initial_hooks`. Closes #141 Signed-off-by: Phoevos Kalemkeris <[email protected]>
phoevos
suggested changes
Jul 27, 2023
phoevos
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the CI with standard CI configuration (juju, actions, deps) that is shared across multiple repositories. All python dependencies are also updated to their latest working versions. This PR also includes library updates. Finally, some formatting was applied on non-compliant files (copyright, style).
This change also contains a fix for #147, an issue caused by a missing toolchain in the charm that allows building certain python packages. For more information, please refer to canonical/bundle-kubeflow#648.
Fixes #141
Fixes #147
Part of canonical/bundle-kubeflow#648