Skip to content

PYDEPS linter #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lengau opened this issue Sep 10, 2024 · 1 comment · Fixed by #2250
Closed

PYDEPS linter #1890

lengau opened this issue Sep 10, 2024 · 1 comment · Fixed by #2250
Labels
Enhancement New feature or request triaged

Comments

@lengau
Copy link
Collaborator

lengau commented Sep 10, 2024

What needs to get done

Create a linter to ensure that all dependencies required in PYDEPS in all included charm libs are installed in the venv

Why it needs to get done

With strict deps we don't install from PYDEPS
@lengau lengau added Enhancement New feature or request triaged labels Sep 10, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3370.

This message was autogenerated

@bepri bepri mentioned this issue Oct 18, 2024
Closed
lengau added a commit that referenced this issue Apr 10, 2025
@lengau
feat(linters): PYDEPS linter
65f2b47 
This adds a linter that checks the PYDEPS of all charmlibs in a charm
to ensure the resulting packages match.

Fixes #1890
CRAFT-3370
@lengau lengau mentioned this issue Apr 10, 2025
Merged
@lengau lengau closed this as completed in 8877d1b Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request triaged
Projects
None yet
Milestone
No milestone
1 participant
@lengau