Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizeMode has no effect on base64Placeholder #68

Open
vyobukhov opened this issue Nov 7, 2024 · 2 comments
Open

resizeMode has no effect on base64Placeholder #68

vyobukhov opened this issue Nov 7, 2024 · 2 comments

Comments

@vyobukhov
Copy link

Hi guys,

I've encountered a bug that appears to have been previously reported by @StasKovalov in the comments of another issue. However, it seems that it might have been overlooked and not addressed yet.

resizeMode has no effect on base64Placeholder. It just stretches it randomly.

Here is the link to the relevant comment for your reference: #41 (comment)_

@gtokman
Copy link
Member

gtokman commented Nov 24, 2024

Should be an easy fix by applying the resize mode here:

guard let image = UIImage(base64Placeholder: base64Placeholder) else {
.

I don't have the bandwidth to take this on atm, but if you make a PR, I'll merge it!

@ivansmb11
Copy link

ivansmb11 commented Jan 17, 2025

bandwidth

Have you merged this fix yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants