Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Architecture support (fabric) #38

Open
exploitJ opened this issue May 28, 2024 · 11 comments
Open

New Architecture support (fabric) #38

exploitJ opened this issue May 28, 2024 · 11 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@exploitJ
Copy link

I wonder if your library supports New Architecture(fabric)?

@gtokman
Copy link
Member

gtokman commented May 28, 2024

I'm looking for help on this atm, I haven't done a conversion to fabric on a library yet.

@gtokman gtokman added help wanted Extra attention is needed enhancement New feature or request labels May 28, 2024
@mak12
Copy link

mak12 commented May 30, 2024

Hey, would love to contribute here for fabric support.

@gtokman
Copy link
Member

gtokman commented May 31, 2024

hey 👋🏽 @mak12 that would be awesome :)

@GorbunovV
Copy link

@gtokman Hello. I wanted to know if work is underway to add support for the new architecture?

@gtokman
Copy link
Member

gtokman commented Jun 27, 2024

@GorbunovV not yet from our team. Our app (Candle) is a few iterations from migrating to NA to prioritize, but we would definitely land a PR from the community before that.

@tinker-dev-monk
Copy link

Hey, I've tried both iOS and Android in a fabric environment and it seems to work fine, so it shouldn't cause any issues when I build later?

@jbrodriguez
Copy link

this library supports new architecture (as per their docs) and also uses nuke/coil

duguyihou/react-native-turbo-image: Performant image Component for React Native

@gtokman
Copy link
Member

gtokman commented Nov 6, 2024

It looks like a cool project, but I'd be careful using bc of the binary XCFrameworks included for iOS. This means it's not truly open-source and opens up a concern if there are malicious codes added, as there is no way to verify.

@duguyihou
Copy link

hi @jbrodriguez

Many thanks for mentioning our project. Currently TurboImage supports new architecture because of interop layer. The next step is to rewrite it in Fabric view with backward compat 😄

hi @gtokman

It looks like a cool project, but I'd be careful using bc of the binary XCFrameworks included for iOS. This means it's not truly open-source and opens up a concern if there are malicious codes added, as there is no way to verify.

  • Nuke ships with precompiled XCFrameworks for projects that don't use SwiftPM, which is a trusted source. So we don't need to copy the whole source code of Nuke as a dependency.
  • I can not find any information that help me know using XCFramework as dependency is not truly open-source, can you provide it? Thanks ❤️

@gtokman
Copy link
Member

gtokman commented Nov 30, 2024

Here's a direct link by Apple.

When you add third-party binary SDKs to your target as XCFrameworks, the behaviors of those packages become part of the behavior of your product. An attacker who’s able to inject a compromised version of the SDK into your project could change your app’s behavior and cause security and privacy issues for your developers, testers, and people who use your product.

I commented that it's a tradeoff I would consider as a developer when using an open-source project. Open-source thrives on transparency + allowing anyone to inspect and verify the code. As Apple mentioned, a precompiled binary obscures the underlying implementation, making it impossible to audit for malicious code or unintended behavior.

@duguyihou
Copy link

Yes, I agree it is a tradeoff. People still can verify the code from Nuke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants