-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Architecture support (fabric) #38
Comments
I'm looking for help on this atm, I haven't done a conversion to fabric on a library yet. |
Hey, would love to contribute here for fabric support. |
hey 👋🏽 @mak12 that would be awesome :) |
@gtokman Hello. I wanted to know if work is underway to add support for the new architecture? |
@GorbunovV not yet from our team. Our app (Candle) is a few iterations from migrating to NA to prioritize, but we would definitely land a PR from the community before that. |
Hey, I've tried both iOS and Android in a fabric environment and it seems to work fine, so it shouldn't cause any issues when I build later? |
this library supports new architecture (as per their docs) and also uses nuke/coil duguyihou/react-native-turbo-image: Performant image Component for React Native |
It looks like a cool project, but I'd be careful using bc of the binary XCFrameworks included for iOS. This means it's not truly open-source and opens up a concern if there are malicious codes added, as there is no way to verify. |
hi @jbrodriguez Many thanks for mentioning our project. Currently TurboImage supports new architecture because of interop layer. The next step is to rewrite it in hi @gtokman
|
Here's a direct link by Apple.
I commented that it's a tradeoff I would consider as a developer when using an open-source project. Open-source thrives on transparency + allowing anyone to inspect and verify the code. As Apple mentioned, a precompiled binary obscures the underlying implementation, making it impossible to audit for malicious code or unintended behavior. |
Yes, I agree it is a tradeoff. People still can verify the code from Nuke |
I wonder if your library supports New Architecture(fabric)?
The text was updated successfully, but these errors were encountered: