Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augeas lens don't support latest Puppetfile syntax #19

Closed
vchepkov opened this issue Mar 1, 2019 · 3 comments
Closed

augeas lens don't support latest Puppetfile syntax #19

vchepkov opened this issue Mar 1, 2019 · 3 comments
Labels

Comments

@vchepkov
Copy link
Contributor

vchepkov commented Mar 1, 2019

augeas lens in updater fails to process latest syntax in Puppetfile, for example

mod 'classification',
  :git => 'ssh://git@stash/bp/puppet-classification.git',
  :branch => :control_branch

task fails:

Failed to parse Puppetfile at line 2, character 56: Iterated lens matched less than it should

There are several improvements have been added by r10k which make it easier to create dynamic environments, here is an example form a working puppetfile:

mod 'report_slack',
  :git    => 'ssh://git@stash/bp/report_slack.git',
  :branch => :control_branch,
  :default_branch => 'master'

mod 'site',
  :git    => 'ssh://git@stash/bp/puppet-site.git',
  :branch => 'production',
  :install_path => '.'

It would be nice to extend lens to support them.

Thanks
Vadym

@vchepkov
Copy link
Contributor Author

vchepkov commented Apr 4, 2019

lens was fixed in upstream, thank you hercules-team/augeas#619

@raphink
Copy link
Contributor

raphink commented Apr 5, 2019

Yes, I guess I could copy the changes here, too.

@raphink
Copy link
Contributor

raphink commented Apr 5, 2019

Updated lens from upstream in d18bc00

@raphink raphink closed this as completed Apr 5, 2019
@raphink raphink added the bug label Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants