Skip to content

Conversation

@manishpatwari-dev
Copy link

Cause: Empty horizontal and vertical dictionaries in t_bbox in method _text_bbox(t_bbox)

Resolution: Added len check condition on t_bbox before updating (xmin, ymin, xmax, ymax) and initialised (xmin, ymin, xmax, ymax) to 0 if len is 0

Cause: Empty horizontal and vertical dictionaries in t_bbox in method _text_bbox(t_bbox)

Resolution: Added len check condition on t_bbox before updating (xmin, ymin, xmax, ymax) and initialised (xmin, ymin, xmax, ymax) to 0 if len is 0
Copy link
Collaborator

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosd bosd mentioned this pull request Jul 15, 2023
@MartinThoma
Copy link
Collaborator

Hey!

As camelot is dead, we try to build a maintained fork at pypdf_table_extraction.

Do you want to open the PR against that branch so that we can merge your improvement?

@DoomedJupiter
Copy link
Collaborator

This change was previously merged and since removed from the codebase in commit 9a5fd58. Closing as OBE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants