Max mohammadi #68
Open
Max mohammadi #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfekadu
reviewed
Feb 25, 2020
There was a problem hiding this comment.
Code looks very good @MaxMohammadi !!
Thank for your contribution
My only request is that you test the code by running the following within __main__
# setup test
db = NimbusMySQLAlchemy()
db._create_all_tables()
data = {
# insert example input keys and values
}
db.save_rpi_logs(data)
# do the test
FOO = db.get_property_from_entity(
prop="input_question", # you could do whatever Column name you care about
entity=db.RPILogs,
entity_string="whatever value you put for input_question in data"
)
assert FOO == ['whatever value']Then commit your tested code or include a screenshot here
NOTE: if you run the above test multiple times then the assertion will fail because on the second try you will have save_rpi_logs twice
Feel free to come up with your own test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
Scraped RasperryPiLogs are saved in the database with the save_rpi_logs() function in database_wrapper.py.
Fixes #60
Type of change (pick-one)
Checklist (check-all-before-merge)
formatting help:
- [x]means "checked' and- [ ]means "unchecked"I documented my code according to the Google Python Style Guide
I ran
./build_docs.shand the docs look fineI ran
./type_check.shand got no errorsI ran
./format.shbecause it automatically cleans my code for me 😄I ran
./lint.shto check for what "format" missedI added my tests to the
/testsdirectoryI ran
./run_tests.shand all the tests pass