Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Build GH action to run perf tests #58

Open
mdjastrzebski opened this issue Jun 23, 2022 · 5 comments
Open

[FEATURE] Build GH action to run perf tests #58

mdjastrzebski opened this issue Jun 23, 2022 · 5 comments
Labels
feature help wanted Extra attention is needed

Comments

@mdjastrzebski
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently we piggy back on Danger JS to offer support to popular CIs. This request is about building direct integration with GitHub actions.

Describe the solution you'd like

  • GH action that directly integrates with Reassure.
  • Separate package in the monorepo
  • Does not use Danger JS

Describe alternatives you've considered
None

Additional context
None

@mdjastrzebski mdjastrzebski added feature help wanted Extra attention is needed labels Jun 23, 2022
@ShaswatPrabhat
Copy link
Contributor

Hey @mdjastrzebski ,

Can you please share a bit more context on the action ?
When we say we are seeking to support an action that integrates with Reassure on the CI ...

@ShaswatPrabhat
Copy link
Contributor

ShaswatPrabhat commented Oct 5, 2022

Hi @mdjastrzebski ,

I wanted to take a shot at this. Please let me know if we have any other pointers to start with or tech notes on this.

Thanks in advance

@mdjastrzebski
Copy link
Member Author

We basically want to duplicate what our Danger plugin does right now:

  • read the .reassure/output.md file and display the contained markdown inside GH PR
  • fail in case no output file is found
  • in should accept an option to specify the path to output file

That's basically it.

@ShaswatPrabhat
Copy link
Contributor

Thanks @mdjastrzebski I will pick this up and give it a shot.

@ShaswatPrabhat
Copy link
Contributor

ShaswatPrabhat commented Oct 30, 2022

Hey @mdjastrzebski,

Please find the PR for the change.

Was able to integrate it like ShaswatPrabhat/reassure/packages/reassure-gh-action@feat/custom_gh_actions not sure if that is the recommended way though, Had tried a few alternatives before this.

Been able to integrate it, but as the branch is a fork hence not able to run the new job.

Please suggest. Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants