-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add contentStyle to TextInput #3509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @guilherme-ferraz1, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
reviewed
Dec 12, 2022
lukewalczak
reviewed
Dec 12, 2022
This was referenced Dec 12, 2022
@lukewalczak unit test added, prop name changed and minor issues fixed |
Hey @gmferraz, I've analyzed your PR one more time and have two requests, please:
I would like to do the release tomorrow, so please handle it if possible 🙏🏽 |
@lukewalczak done :) |
lukewalczak
requested changes
Dec 18, 2022
lukewalczak
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
contentStyle
prop toTextInput
as requested in #3434This prop allows to pass style props directly to the input itself, not the container.
Test plan
The tests and examples are already updated.
Tested on both IOS and Android with
StyleProp<ViewStyle>
props likepaddingLeft
,backgroundColor
etc.Custom style input example:
contentStyle={{ paddingLeft: 50 }}