fix(fabric): prevent freeze on layout update during transition #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue causing component to freeze when layout was updated during transition
When layout was updated e.g. because of hiding keyboard,
setViewControllers
completion block was never called, which resulted in swipe being disabledIt fixes this issue by preventing layout update during transition phase and updating it after transition ends
Test Plan
Next
page button. (might be required to modifyControlPanel
to move button above keyboard)Other examples should work as before
Compatibility