chore: remove fabric example and migrate to 72 #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troZee
commented
May 19, 2023
example/android/app/src/main/java/com/pagerviewexample/MainActivity.java
Outdated
Show resolved
Hide resolved
troZee
force-pushed
the
feat/old-new-arch-example
branch
from
c960c93 to
e1164b4
Compare
added 2 commits
August 19, 2023 15:30
troZee
changed the title
added 6 commits
August 23, 2023 14:39
This reverts commit d42ccec.
# Conflicts: # example/Gemfile.lock # fabricexample/Gemfile.lock
|
Unfortunately for some reason, the pager is glitching for react native 72 recording.mp4 |
added 3 commits
August 29, 2023 14:18
# Conflicts: # .gitignore # README.md
troZee
force-pushed
the
feat/old-new-arch-example
branch
from
836503b to
f23a5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Maintaining 2 examples (example/fabricexample) at the same the is difficult. This PR adds the ability to have 2 architectures inside one example. In the beginning, the fabric is installed and then we can change to the old one based on the flag.
Test Plan
iOS: Change
_newArchitectureEnabledto false and check if it worksAndroid: Change
farbicEnabledto false and check if it worksCompatibility
Checklist
README.md