Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RN 0.74 #821

Closed
NiuGuohui opened this issue Apr 26, 2024 · 11 comments · Fixed by #829
Closed

Support RN 0.74 #821

NiuGuohui opened this issue Apr 26, 2024 · 11 comments · Fixed by #829
Labels
Resolution: Needs Repro This issue could be improved with a demo to reproduce the issue.

Comments

@NiuGuohui
Copy link
Contributor

Describe the feature

Compatible with version 0.74

Motivation

Related Issues

@troZee
Copy link
Member

troZee commented Apr 26, 2024

Could you provide more context, on what does not work?

@troZee troZee added the Resolution: Needs Repro This issue could be improved with a demo to reproduce the issue. label Apr 26, 2024
@NiuGuohui
Copy link
Contributor Author

Build fail on Android.
This is build output:

...
/app/build/generated/rncli/src/main/jni/rncli.cpp:32:61: error: use of undeclared identifier 'LEGACY_RNCViewPagerComponentDescriptor'
  providerRegistry->add(concreteComponentDescriptorProvider<LEGACY_RNCViewPagerComponentDescriptor>());
...
app/build/generated/rncli/src/main/jni/rncli.cpp:33:61: error: unknown type name 'RNCViewPagerComponentDescriptor'; did you mean 'SharedComponentDescriptor'?
  providerRegistry->add(concreteComponentDescriptorProvider<RNCViewPagerComponentDescriptor>());
                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                            SharedComponentDescriptor

image

@troZee
Copy link
Member

troZee commented Apr 26, 2024

What version of pager?

@NiuGuohui
Copy link
Contributor Author

6.3.1

@troZee
Copy link
Member

troZee commented Apr 29, 2024

Screenshot 2024-04-29 at 11 26 57

We did an investigation and for some reason, cpp code does not see those modules

@NiuGuohui
Copy link
Contributor Author

Screenshot 2024-04-29 at 11 26 57 We did an investigation and for some reason, cpp code does not see those modules

so how to resolve this problem? I'm not very familiar with C++.

@troZee
Copy link
Member

troZee commented Apr 29, 2024

We did not, we are still looking for a cause of this problem

@nikitapilgrim
Copy link

iOS build same problem

@sriharsha-y
Copy link

It might be same as mentioned here #822 (comment)

@sulemanbutt10
Copy link

can anyone please guide which version of react-native-pager-view is compatible with react-native (v0.71.18)

i am also using other libraries:

react-native-collapsible-tab-view
react-native-head-tab-view
react-native-tab-view-collapsible-header

i also have to update these ones as well according to react native (v0.71.18)
can anyone please guide?

@troZee
Copy link
Member

troZee commented Jun 19, 2024

Resolved in #829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Repro This issue could be improved with a demo to reproduce the issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants