Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #233

Closed
troZee opened this issue Sep 29, 2020 · 6 comments
Closed

Roadmap #233

troZee opened this issue Sep 29, 2020 · 6 comments

Comments

@troZee
Copy link
Member

troZee commented Sep 29, 2020

Revert stable version of ViewPager on Android (version v4.2.0) (@troZee)

In the 4.x.x version, native implementation of ViewPager has been updated to a higher version, which is V2. V2 version uses another implementation (Recycler View) than V1. Community noticed lots of issues in the V2 version, hence I would like to revert viewpager to V1 and create a separate branch for V2.

action items:

  • update a readme
  • describe a breaking changes
  • create a PR
  • setup a npm next and latest tags (latest4.2.0 next: 5.x.x)

Create a separate workspaces for lib and example: (no version affected) (@troZee )

Each library repository should provide an example of library usage. This example should cover a common use cases. In the ViewPager example, I would like to add some dependencies like react-navigation, to be able to test ViewPager with other libs.

Example of separate workspaces: callstack/react-native-slider@5220303

action items:

  • create a PR
  • setup a npm

Add more examples: (no version affected)

People use VP in various cases. Currently the library provides only one simple case, hence it is hard to reproduce some issues.

Example cases:
VP inside FlatList
FlatList inside VP
more and more

If you would like to add an example to lib, don't hesitate and please reach me out in this ticket.

Add known issues section to README file (no version affected) (everyone can take it)

Known issues:

[iOS]: In case of UIViewControllerHierarchyInconsistency error, please use below fix:

requestAnimationFrame(() => refViewPager.current?.setPage(index));

E2E tests: (no version affected) (optional)

This library is purely native. JS part is only responsible for exposing view and methods, which can be used inside React components. I would like to cover some cases, which I did for each PR (swiping between each page, deleting each page)

@troZee troZee pinned this issue Sep 29, 2020
@mqtik
Copy link

mqtik commented Oct 10, 2020

Is there an onLoaded function?

@yodaheis
Copy link

Any ETA on this? Also which is the most stable version as far as Android is concerned?

@troZee
Copy link
Member Author

troZee commented Oct 25, 2020

Any ETA on this? Also which is the most stable version as far as Android is concerned?

It is hard to say about ETA. I will try to revert android to the stable one in this week. I will put an update here.

@troZee
Copy link
Member Author

troZee commented Oct 28, 2020

@yodaheis FYI: The ViewPager has been reverted to a stable version in 4.2

@troZee
Copy link
Member Author

troZee commented Mar 5, 2021

All of those things has been resolved, hence I close this issue.

@troZee troZee closed this as completed Mar 5, 2021
@fukemy
Copy link

fukemy commented Aug 26, 2022

i still got error

 Assertion failure in -[UIPageViewController queuingScrollView:willManuallyScroll:toRevealView:concealView:animated:], UIPageViewController.m:1966
2022-08-26 19:32:28.000980+0700 VedaxLink[15191:14589608] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Unexpected view controller: <UIViewController: 0x175b84ff0>'
*** First throw call stack:
(
	0   CoreFoundation                      0x0000000109dbbd70 __exceptionPreprocess + 236
	1   libobjc.A.dylib                     0x00000001068a214c objc_exception_throw + 56
	2   Foundation                          0x000000010ace7560 _userInfoForFileAndLine + 0
	3   UIKitCore                           0x00000001263c10c8 -[UIPageViewController queuingScrollView:willManuallyScroll:toRevealView:concealView:animated:] + 964
	4   UIKitCore                           0x00000001263cd764 -[_UIQueuingScrollView _notifyDelegateWillManuallyScroll:toRevealView:concealingView:animated:] + 132
	5   UIKitCore                           0x00000001263ceaf4 __54-[_UIQueuingScrollView _didScrollWithAnimation:force:]_block_invoke + 452
	6   UIKitCore                           0x00000001263ce72c -[_UIQueuingScrollView _didScrollWithAnimation:force:] + 604
	7   UIKitCore                           0x00000001263cac34 -[_UIQueuingScrollView layoutSubviews] + 188
	8   UIKitCore                           0x0000000127124434 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 2588
	9   QuartzCore                          0x000000010b9148ec _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 472
	10  QuartzCore                          0x000000010b91f6f0 _ZN2CA5Layer28layout_and_display_if_neededEPNS_11TransactionE + 116
	11  QuartzCore                          0x000000010b85853c _ZN2CA7Context18commit_transactionEPNS_11TransactionEdPd + 448
	12  QuartzCore                          0x000000010b884554 _ZN2CA11Transaction6commitEv + 696
	13  QuartzCore                          0x000000010b8857ac _ZN2CA11Transaction25flush_as_runloop_observerEb + 68
	14  CoreFoundation                      0x0000000109d28f10 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 32
	15  CoreFoundation                      0x0000000109d235a4 __CFRunLoopDoObservers + 572
	16  CoreFoundation                      0x0000000109d23af8 __CFRunLoopRun + 968
	17  CoreFoundation                      0x0000000109d23218 CFRunLoopRunSpecific + 572
	18  GraphicsServices                    0x0000000112bab60c GSEventRunModal + 160
	19  UIKitCore                           0x0000000126bb5a98 -[UIApplication _run] + 992
	20  UIKitCore                           0x0000000126bba634 UIApplicationMain + 112
	21  VedaxLink                           0x0000000104788290 main + 80
	22  dyld                                0x0000000106275cd8 start_sim + 20
	23  ???                                 0x00000001061c508c 0x0 + 4397486220
	24  ???                                 0x6f21800000000000 0x0 + 8007822349929807872
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants