[TableHeader] Can't unselect all when enableSelectAll={true}

[mbrookes]

When enableSelectAll is enabled, the TableHeader checkbox can be used to enable all rows, but doesn't disable all when clicked.

[mbrookes]

Steps to reproduce:

1. Go to the docs site: Components / Table / Complex example
2. Turn on Multi-Selectable and Enable Select All
3. Click the header checkbox (all items selected)
4. Click it again. Nada.

[scottsilvi]

FYI, I've been diving into area of code as a result of an unrelated issue. What I've discovered is, if I remove the following code inside of table-body.jsx > componentWillReceiveProps, this behavior is no longer broken.

if (this.props.allRowsSelected && !nextProps.allRowsSelected) {
  newState.selectedRows = this.state.selectedRows.length > 0
    ? [this.state.selectedRows[this.state.selectedRows.length - 1]]
    : [];
} else {
  newState.selectedRows = this._calculatePreselectedRows(nextProps);
}

New to MUI (and react) so I don't necessarily have the context required to know how to fix this, or any 2nd or 3rd order effects, quite yet.

[EDIT TO ADD]
Happy to fix & submit PR if somebody with the requisite context can provide some high-level detail on what this is doing, why it's doing it, etc
[/EDIT]

[vasyas]

Hit the same issue. Any plans on fixing it?

[bedrich-schindler]

I have the same problem. I am unable to unselect all rows using main checkbox in header.

[mbrookes]

Sorry this never got fixed.

Table has already been migrated to (and of I'm not mistaken completely rewritten for) next and so should be resolved there, so I'm closing this for now.