Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): turn dependencies into js #8846

Closed
wants to merge 2 commits into from

Conversation

p6l-richard
Copy link
Contributor

@p6l-richard p6l-richard commented May 11, 2023

What does this PR do?

rewrites files required in website/next-collect.config.js into .js

  • lib/telemetry.ts
  • lib/constants.ts

Fixes # (issue)

enables subdomain routing for i18n on website (requires moving the middleware logic to next.config.js)

Environment: Staging(main branch) / Production

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) May 12, 2023 1:07pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 1:07pm

@github-actions github-actions bot added linear Sync Github Issue from community members to Linear.app 🐛 bug Something isn't working 👩‍🔬 needs investigation labels May 11, 2023
@PeerRich PeerRich requested review from emrysal and keithwillcode May 11, 2023 17:30
@zomars
Copy link
Member

zomars commented May 12, 2023

Can't we just convert next-collect.config.js into next-collect.config.mjs ?

@PeerRich PeerRich closed this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working linear Sync Github Issue from community members to Linear.app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants