Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed discord validation #8536

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

hkirat
Copy link
Contributor

@hkirat hkirat commented Apr 26, 2023

What does this PR do?

Fixes #8182

Environment: Production

Type of change

Bug fix
Adds validation to discord so that discord.com and discord.gg are both accepted

How should this be tested?

Make sure you can add discord.com links in invitations

Screenshot 2023-04-26 at 4 46 13 PM

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 11:21am

@vercel
Copy link

vercel bot commented Apr 26, 2023

@hkirat is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 473.19 KB 623.59 KB 178.17% (🟡 +0.14%)
/auth/setup 190.79 KB 341.19 KB 97.48% (🟢 -0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@CarinaWolli CarinaWolli self-requested a review April 26, 2023 12:44
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🙏

@CarinaWolli CarinaWolli enabled auto-merge (squash) April 26, 2023 12:45
@CarinaWolli CarinaWolli merged commit 55570ed into calcom:main Apr 26, 2023
@@ -16,7 +16,7 @@
"label": "{TITLE}",
"linkType": "static",
"organizerInputPlaceholder": "https://discord.gg/420gg69",
"urlRegExp": "^http(s)?:\\/\\/(www\\.)?discord.gg\\/[a-zA-Z0-9]*"
"urlRegExp": "^http(s)?:\\/\\/(www\\.)?(discord.gg|discord.com)\\/[a-zA-Z0-9]*"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkirat Solution works but it could have been improved by doing the following (discord.gg|discord.com) to discord.(gg|com)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more detailed cases I have managed to cover under: #8612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord URL validation incorrect
5 participants