Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord URL validation incorrect #8182

Closed
elliottcal opened this issue Apr 11, 2023 · 6 comments · Fixed by #8536
Closed

Discord URL validation incorrect #8182

elliottcal opened this issue Apr 11, 2023 · 6 comments · Fixed by #8536
Labels
🐛 bug Something isn't working ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated

Comments

@elliottcal
Copy link

Issue Summary

Using the new Discord App on V2.7.10 (self hosted), the URL validation doesn't allow Discord links that are not discord.gg e.g. discord.com/channels...does not work.

It should be able to handle discord.gg and discord.com links.

image

Steps to Reproduce

  1. Create a new or use existing event type
  2. Add a location
  3. Click Discord
  4. Add a Discord URL that isn't discord.gg
  5. Shows validation error

Technical details

  1. Microsoft Edge - 111.0.1661.44 (Official build) (arm64)
@maige-app maige-app bot added the 🐛 bug Something isn't working label Apr 11, 2023
@elliottcal
Copy link
Author

elliottcal commented Apr 20, 2023 •
edited
Loading

Still doesn't work in 2.8.5. What validation is it doing on the URL?

SCR-20230420-lbfa-2

@elliottcal
Copy link
Author

Still doesn't work in V2.8.9

@hariombalhara
Copy link
Member

It expects discord.gg

@elliottcal
Copy link
Author

That's exactly what I've shared above. It should also be able to handle discord.com

@hariombalhara
Copy link
Member

cc @PeerRich

@PeerRich
Copy link
Member

yeah lets allow both.

the discord.gg is the invite link

@hariombalhara hariombalhara added ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated labels Apr 25, 2023
@hkirat hkirat mentioned this issue Apr 26, 2023
Merged
@hiteshbedre hiteshbedre mentioned this issue May 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed discord validation hkirat/cal.com
3 participants
@hariombalhara @PeerRich @elliottcal