Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-create dbt artifact Pydantic classes from official jsonschema #2546

Closed
atvaccaro opened this issue May 1, 2023 · 0 comments · Fixed by #2545 or #2598
Closed

Re-create dbt artifact Pydantic classes from official jsonschema #2546

atvaccaro opened this issue May 1, 2023 · 0 comments · Fixed by #2545 or #2598
Assignees

Comments

@atvaccaro
Copy link
Contributor

atvaccaro commented May 1, 2023

We should use https://docs.pydantic.dev/latest/datamodel_code_generator combined with schemas.getdbt.com to produce generated classes that we can inherit, or just use as fixed types and write more function-oriented code. This will be easier to update/maintain than custom classes.

This was done in #2545 but we hit an issue with dbt 1.5 so we reverted.

I need to change the dbt test fingerprints to use the string value of the status enum. Otherwise, the fingerprint will change if the type of the enum differs.

We should merge/resolve issues as necessary after this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant