From ee000e691726cd0daa2c257aa3eccc0756d24203 Mon Sep 17 00:00:00 2001 From: Simon Cropp Date: Wed, 27 Aug 2025 21:35:31 +1000 Subject: [PATCH] avoid string.Join(string.Empty --- .../Unit/Tools/MSBuild/MSBuildSettingsExtensionsTests.cs | 2 +- src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs | 2 +- src/Cake.Core/Diagnostics/Formatting/FormatParser.cs | 2 +- src/Cake.Core/IO/Globbing/GlobTokenizer.cs | 2 +- src/Cake.Core/Scripting/CodeGen/ParameterEmitter.cs | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildSettingsExtensionsTests.cs b/src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildSettingsExtensionsTests.cs index 2d9b2c1549..11ad8d9478 100644 --- a/src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildSettingsExtensionsTests.cs +++ b/src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildSettingsExtensionsTests.cs @@ -184,7 +184,7 @@ public void Should_Set_Platform_Target_Via_Property() // Then Assert.True(settings.Properties.ContainsKey("Platform")); - Assert.Equal("Custom", string.Join(string.Empty, settings.Properties["Platform"])); + Assert.Equal("Custom", string.Concat(settings.Properties["Platform"])); } [Fact] diff --git a/src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs b/src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs index 23520230c9..63f8e681b0 100644 --- a/src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs +++ b/src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs @@ -318,7 +318,7 @@ private void WriteLoggingCommand(string actionName, string value) private void WriteLoggingCommand(string actionName, Dictionary properties, string value) { - var props = string.Join(string.Empty, properties.Select(pair => + var props = string.Concat(properties.Select(pair => { return string.Format(CultureInfo.InvariantCulture, "{0}={1};", pair.Key, pair.Value); })); diff --git a/src/Cake.Core/Diagnostics/Formatting/FormatParser.cs b/src/Cake.Core/Diagnostics/Formatting/FormatParser.cs index 42f34d5386..653ad9ee45 100644 --- a/src/Cake.Core/Diagnostics/Formatting/FormatParser.cs +++ b/src/Cake.Core/Diagnostics/Formatting/FormatParser.cs @@ -80,7 +80,7 @@ private static FormatToken ParseProperty(CharReader reader) if (parts.Length > 1) { var name = parts[0]; - var format = string.Join(string.Empty, parts.Skip(1)); + var format = string.Concat(parts.Skip(1)); var positional = IsNumeric(name); if (!positional) { diff --git a/src/Cake.Core/IO/Globbing/GlobTokenizer.cs b/src/Cake.Core/IO/Globbing/GlobTokenizer.cs index edbc106df6..191307cfe5 100644 --- a/src/Cake.Core/IO/Globbing/GlobTokenizer.cs +++ b/src/Cake.Core/IO/Globbing/GlobTokenizer.cs @@ -47,7 +47,7 @@ private static GlobTokenBuffer Tokenize(StringReader reader) } accumulator.Add(queue.Dequeue()); } - result.Add(new GlobToken(GlobTokenKind.Text, string.Join(string.Empty, accumulator.Select(i => i.Value)))); + result.Add(new GlobToken(GlobTokenKind.Text, string.Concat(accumulator.Select(i => i.Value)))); } else { diff --git a/src/Cake.Core/Scripting/CodeGen/ParameterEmitter.cs b/src/Cake.Core/Scripting/CodeGen/ParameterEmitter.cs index ff08343413..b7989e8d9f 100644 --- a/src/Cake.Core/Scripting/CodeGen/ParameterEmitter.cs +++ b/src/Cake.Core/Scripting/CodeGen/ParameterEmitter.cs @@ -30,7 +30,7 @@ internal sealed class ParameterEmitter internal static string Emit(ParameterInfo parameter, bool includeType) { - return string.Join(string.Empty, BuildParameterTokens(parameter, includeType)); + return string.Concat(BuildParameterTokens(parameter, includeType)); } private static IEnumerable BuildParameterTokens(ParameterInfo parameter, bool includeType)