Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for captions #17

Open
ian-cox opened this issue Jul 28, 2020 · 3 comments
Open

Support for captions #17

ian-cox opened this issue Jul 28, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ian-cox
Copy link

ian-cox commented Jul 28, 2020

Would be awesome to be able to include a caption for each gallery image.
image

Would also be super useful to be able to add a caption for a group of images in the gallery block settings.
image

@cajames cajames added the enhancement New feature or request label Aug 7, 2020
@cajames
Copy link
Owner

cajames commented Aug 7, 2020

@ian-cox another great feature request. 😊

Doing a caption per image should be quite possible, though would it be different to the alt text?

Regarding a caption for the whole gallery, I've actually been working on something for this haha. Just a few tricky bits as a "gallery" is a grouping of adjacent blocks. So the caption technically is just on the "last" block of galleries for it to get displayed. Though at the moment I don't know if there's an easy way to analyse the entire structure of blocks on the client-side in Vue. I'll some more time in a few weeks where I'll spend more time looking into this. 😊

@ian-cox
Copy link
Author

ian-cox commented Aug 7, 2020

Awesome! thanks for looking into this

@Jasper2-0
Copy link
Contributor

@cajames from a user perspective having a caption seems to make more sense than an alt-text; that is, setting a caption should also set the alt-text attribute of the image. Conceptually a caption is part of the content of an image, while an alt-tag is primarily an attribute to enhance web-accessibility... In my experience that technical distinction doesn't matter that much to users...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants