-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emojis don't render properly on all terminals #143
Comments
Another good solution would be to make the emojis configurable, so that the end user can decide if they should be printed to the console or not. Proposal: var logger = logdown({ icons: false }) WDYT @SleepWalker & @caiogondim ? |
Configurable it's good! But is should be enabled by default to keep
backward compatibility.
… |
What would be better? const logger1 = logdown({ icons: false })
const logger2 = logdown({ icons: {
warning: '!',
error: '!!'
} }) What do you think? |
The easiest to implement (and already useful) config would be turning it on or off completely. |
I'm cool with that |
Emojis cannot be rendered on every terminal. This causes the issue that log messages will look strange and don't have a common alignment.
You can see the issue by running my demo code in different terminals:
Because the output isn't consistent across platforms, we should replace emojis with standard ASCII symbols (which can be rendered on most of the systems).
I also noticed that
logger.debug
is not printed on the console. How can I getdebug
messages? I already usedNODE_DEBUG=*
.Command-line interface (Windows)
PowerShell (Windows)
Ubuntu Bash (Linux Subsystem on Windows 10)
The text was updated successfully, but these errors were encountered: