refactor: remove update feature from root command

cage1016 · cage1016 · commit 29425bdac7f4 · 2023-08-03T23:43:32.000+08:00
- Remove import statements for &amp;#34;os&amp;#34; and &amp;#34;os/exec&amp;#34; in `root.go`
- Remove `CheckForUpdate` function from `root.go`
- Delete the `update.go` file, which includes the removal of the `updateCmd` command.

Signed-off-by: Kai-Chu Chung &lt;cage.chung@gmail.com&gt;
diff --git a/cmd/binary.go b/cmd/binary.go
@@ -30,8 +30,6 @@ func runBinary(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	_, err := strconv.ParseUint(query, 2, 64)
 	if err != nil {
 		wf.NewItem(fmt.Sprintf("`%s` is invalid binary", query)).Subtitle("Try a different query?").Icon(NumberGrayIcon)
diff --git a/cmd/case.go b/cmd/case.go
@@ -60,8 +60,6 @@ func runCase(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	t, _ := cmd.Flags().GetString("type")
 	if t == "command" {
 		keys := make([]string, 0, len(M))
diff --git a/cmd/checksum.go b/cmd/checksum.go
@@ -29,8 +29,6 @@ func runChecksum(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	s, err := lib.NewCheckSum(query)
 	if err != nil {
 		wf.NewItem(fmt.Sprintf("`%s` is invalid file", query)).Subtitle("Try a different query?").Icon(HashGrayIcon)
diff --git a/cmd/decimal.go b/cmd/decimal.go
@@ -31,8 +31,6 @@ func runDecimal(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	c, err := strconv.ParseUint(query, 10, 64)
 	if err != nil {
 		wf.NewItem(fmt.Sprintf("`%s` is invalid decimal", query)).Subtitle("Try a different query?").Icon(NumberGrayIcon)
diff --git a/cmd/decode.go b/cmd/decode.go
@@ -28,8 +28,6 @@ func decodeRun(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	coder := lib.NewDecoder()
 	b64DecodeStr := coder.Base64(query)
 	wf.NewItem(b64DecodeStr).
diff --git a/cmd/encode.go b/cmd/encode.go
@@ -28,8 +28,6 @@ func encodeRun(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	coder := lib.NewEncoder()
 	b64EncodeStr := coder.Base64(query)
 	wf.NewItem(b64EncodeStr).
diff --git a/cmd/hash.go b/cmd/hash.go
@@ -28,8 +28,6 @@ func runHash(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	md5Str := lib.MD5(query)
 	wf.NewItem(md5Str).
 		Subtitle("⌘+L, ↩ Copy MD5").
diff --git a/cmd/hexadecimal.go b/cmd/hexadecimal.go
@@ -30,8 +30,6 @@ func runHexadecimal(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	_, err := strconv.ParseUint(query, 16, 64)
 	if err != nil {
 		wf.NewItem(fmt.Sprintf("`%s` is invalid hexadecimal", query)).Subtitle("Try a different query?").Icon(NumberGrayIcon)
diff --git a/cmd/imageB64.go b/cmd/imageB64.go
@@ -41,8 +41,6 @@ func runImageB64(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	var err error
 	if reUrl.Match([]byte(query)) {
 		query, err = lib.Download(query, wf.DataDir())
diff --git a/cmd/json.go b/cmd/json.go
@@ -29,8 +29,6 @@ func runJSON(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	j := lib.NewJSONFormat()
 	if j.IsJSON(query) {
 		wf.NewItem(query).
diff --git a/cmd/jwt.go b/cmd/jwt.go
@@ -30,8 +30,6 @@ func runJwt(c *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	token, err := lib.JWTdecode(query)
 	if err == nil {
 		a, _ := json.Marshal(token.Header)
diff --git a/cmd/loremipsum.go b/cmd/loremipsum.go
@@ -35,8 +35,6 @@ func runLorem(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	c, err := strconv.ParseInt(query, 10, 64)
 	if err != nil {
 		wf.NewItem(fmt.Sprintf("`%s` is invalid integer", query)).Subtitle("Try a different query?").Icon(LoremIpsumGrayIcon)
diff --git a/cmd/nscommand.go b/cmd/nscommand.go
@@ -16,7 +16,6 @@ var nscommandCmd = &cobra.Command{
 }
 
 func runNsCommand(cmd *cobra.Command, args []string) {
-	CheckForUpdate()
 
 	wf.NewItem("Binary To ➜").Subtitle("↩ Launch Decimal, Octal, Hexadecimal").Valid(true).UID("1").Icon(NumberIcon).Var("type", "binary")
 	wf.NewItem("Decimal To ➜").Subtitle("↩ Launch Binary, Octal, Hexadecimal").Valid(true).UID("2").Icon(NumberIcon).Var("type", "decimal")
diff --git a/cmd/octal.go b/cmd/octal.go
@@ -30,8 +30,6 @@ func runOctal(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	_, err := strconv.ParseUint(query, 8, 64)
 	if err != nil {
 		wf.NewItem(fmt.Sprintf("`%s` is invalid octal", query)).Subtitle("Try a different query?").Icon(NumberGrayIcon)
diff --git a/cmd/qrcode.go b/cmd/qrcode.go
@@ -60,8 +60,6 @@ func runQrcode(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	path := fmt.Sprintf("%s/qr.png", wf.DataDir())
 	s, err := strconv.Atoi(alfred.GetQrcodeSize(wf))
 	if err != nil {
diff --git a/cmd/root.go b/cmd/root.go
@@ -1,13 +1,9 @@
 /*
 Copyright © 2022 KAI CHU CHUNG <cage.chung@gmail.com>
-
 */
 package cmd
 
 import (
-	"os"
-	"os/exec"
-
 	aw "github.com/deanishe/awgo"
 	"github.com/deanishe/awgo/update"
 	"github.com/sirupsen/logrus"
@@ -23,31 +19,11 @@ var (
 	wf   *aw.Workflow
 )
 
-func CheckForUpdate() {
-	if wf.UpdateCheckDue() && !wf.IsRunning(updateJobName) {
-		logrus.Info("Running update check in background...")
-		cmd := exec.Command(os.Args[0], "update")
-		if err := wf.RunInBackground(updateJobName, cmd); err != nil {
-			logrus.Errorf("Error starting update check: %s", err)
-		}
-	}
-
-	if wf.UpdateAvailable() {
-		wf.Configure(aw.SuppressUIDs(true))
-		wf.NewItem("An update is available!").
-			Subtitle("⇥ or ↩ to install update").
-			Valid(false).
-			Autocomplete("workflow:update").
-			Icon(&aw.Icon{Value: "download.pdf"})
-	}
-}
-
 // rootCmd represents the base command when called without any subcommands
 var rootCmd = &cobra.Command{
 	Use:   "alfred-devtoys",
 	Short: "A Swiss Army knife for developers for Alfred",
 	Run: func(cmd *cobra.Command, args []string) {
-		CheckForUpdate()
 		wf.SendFeedback()
 	},
 }
diff --git a/cmd/time.go b/cmd/time.go
@@ -33,7 +33,6 @@ type TimeFormatItem struct {
 }
 
 func runTimeCmd(cmd *cobra.Command, args []string) {
-	CheckForUpdate()
 
 	var query int64
 	var err error
diff --git a/cmd/timeCopy.go b/cmd/timeCopy.go
@@ -23,7 +23,6 @@ var timeCopyCmd = &cobra.Command{
 }
 
 func runTimeCopyCmd(cmd *cobra.Command, args []string) {
-	CheckForUpdate()
 
 	prefFile := path.Join(wf.Dir(), "info.plist")
 	if dpf := os.Getenv("DEBUG_PLIST_FOLDER"); dpf != "" {
diff --git a/cmd/update.go b/cmd/update.go
diff --git a/cmd/uuid.go b/cmd/uuid.go
@@ -35,8 +35,6 @@ func runUuid(cmd *cobra.Command, args []string) {
 	}
 	logrus.Debugf("query: %s", query)
 
-	CheckForUpdate()
-
 	c, err := strconv.ParseInt(query, 10, 64)
 	if err != nil {
 		wf.NewItem(fmt.Sprintf("`%s` is invalid integer", query)).Subtitle("Try a different query?").Icon(UuidGrayIcon)

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,6 @@ func runBinary(cmd *cobra.Command, args []string) {`
`30`	`30`	`}`
`31`	`31`	`logrus.Debugf("query: %s", query)`
`32`	`32`
`33`		`- CheckForUpdate()`
`34`		`-`
`35`	`33`	`_, err := strconv.ParseUint(query, 2, 64)`
`36`	`34`	`if err != nil {`
`37`	`35`	wf.NewItem(fmt.Sprintf("`%s` is invalid binary", query)).Subtitle("Try a different query?").Icon(NumberGrayIcon)
Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,6 @@ func runCase(cmd *cobra.Command, args []string) {`
`60`	`60`	`}`
`61`	`61`	`logrus.Debugf("query: %s", query)`
`62`	`62`
`63`		`- CheckForUpdate()`
`64`		`-`
`65`	`63`	`t, _ := cmd.Flags().GetString("type")`
`66`	`64`	`if t == "command" {`
`67`	`65`	`keys := make([]string, 0, len(M))`
Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,6 @@ func runChecksum(cmd *cobra.Command, args []string) {`
`29`	`29`	`}`
`30`	`30`	`logrus.Debugf("query: %s", query)`
`31`	`31`
`32`		`- CheckForUpdate()`
`33`		`-`
`34`	`32`	`s, err := lib.NewCheckSum(query)`
`35`	`33`	`if err != nil {`
`36`	`34`	wf.NewItem(fmt.Sprintf("`%s` is invalid file", query)).Subtitle("Try a different query?").Icon(HashGrayIcon)
Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@ func runDecimal(cmd *cobra.Command, args []string) {`
`31`	`31`	`}`
`32`	`32`	`logrus.Debugf("query: %s", query)`
`33`	`33`
`34`		`- CheckForUpdate()`
`35`		`-`
`36`	`34`	`c, err := strconv.ParseUint(query, 10, 64)`
`37`	`35`	`if err != nil {`
`38`	`36`	wf.NewItem(fmt.Sprintf("`%s` is invalid decimal", query)).Subtitle("Try a different query?").Icon(NumberGrayIcon)
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@ func decodeRun(cmd *cobra.Command, args []string) {`
`28`	`28`	`}`
`29`	`29`	`logrus.Debugf("query: %s", query)`
`30`	`30`
`31`		`- CheckForUpdate()`
`32`		`-`
`33`	`31`	`coder := lib.NewDecoder()`
`34`	`32`	`b64DecodeStr := coder.Base64(query)`
`35`	`33`	`wf.NewItem(b64DecodeStr).`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@ func encodeRun(cmd *cobra.Command, args []string) {`
`28`	`28`	`}`
`29`	`29`	`logrus.Debugf("query: %s", query)`
`30`	`30`
`31`		`- CheckForUpdate()`
`32`		`-`
`33`	`31`	`coder := lib.NewEncoder()`
`34`	`32`	`b64EncodeStr := coder.Base64(query)`
`35`	`33`	`wf.NewItem(b64EncodeStr).`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@ func runHash(cmd *cobra.Command, args []string) {`
`28`	`28`	`}`
`29`	`29`	`logrus.Debugf("query: %s", query)`
`30`	`30`
`31`		`- CheckForUpdate()`
`32`		`-`
`33`	`31`	`md5Str := lib.MD5(query)`
`34`	`32`	`wf.NewItem(md5Str).`
`35`	`33`	`Subtitle("⌘+L, ↩ Copy MD5").`
Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,6 @@ func runHexadecimal(cmd *cobra.Command, args []string) {`
`30`	`30`	`}`
`31`	`31`	`logrus.Debugf("query: %s", query)`
`32`	`32`
`33`		`- CheckForUpdate()`
`34`		`-`
`35`	`33`	`_, err := strconv.ParseUint(query, 16, 64)`
`36`	`34`	`if err != nil {`
`37`	`35`	wf.NewItem(fmt.Sprintf("`%s` is invalid hexadecimal", query)).Subtitle("Try a different query?").Icon(NumberGrayIcon)
Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,6 @@ func runImageB64(cmd *cobra.Command, args []string) {`
`41`	`41`	`}`
`42`	`42`	`logrus.Debugf("query: %s", query)`
`43`	`43`
`44`		`- CheckForUpdate()`
`45`		`-`
`46`	`44`	`var err error`
`47`	`45`	`if reUrl.Match([]byte(query)) {`
`48`	`46`	`query, err = lib.Download(query, wf.DataDir())`
Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,6 @@ func runJSON(cmd *cobra.Command, args []string) {`
`29`	`29`	`}`
`30`	`30`	`logrus.Debugf("query: %s", query)`
`31`	`31`
`32`		`- CheckForUpdate()`
`33`		`-`
`34`	`32`	`j := lib.NewJSONFormat()`
`35`	`33`	`if j.IsJSON(query) {`
`36`	`34`	`wf.NewItem(query).`