Remove payload from Thrift converter deprecation log and add additional log for TEnumType converter (#1011)

What changed?

added deprecation log for TEnumType converter
log only payload class rather than body
Why?

In V4, default support for thrift message will be dropped

Author: shijiesheng

src/main/java/com/uber/cadence/converter/TBaseTypeAdapterFactory.java

@@ -65,8 +65,8 @@ public void write(JsonWriter jsonWriter, T value) throws IOException {
                   newThriftSerializer().toString((TBase) value, StandardCharsets.UTF_8.name());
               jsonWriter.value(result);
               logger.warn(
-                  "TBase message will no longer be support in cadence-java-client V4, payload {}",
-                  result);
+                  "Thrift message will no longer be supported for data conversion in cadence-java-client V4, payload class name {}",
+                  result.getClass().getName());
             } catch (TException e) {
               throw new DataConverterException("Failed to serialize TBase", e);
             }
@@ -79,13 +79,13 @@ public T read(JsonReader jsonReader) throws IOException {
             }
             String value = jsonReader.nextString();
             try {
-              logger.warn(
-                  "TBase message will no longer be support in cadence-java-client V4, payload {}",
-                  value);
               @SuppressWarnings("unchecked")
               T instance = (T) typeToken.getRawType().getConstructor().newInstance();
               newThriftDeserializer()
                   .deserialize((TBase) instance, value, StandardCharsets.UTF_8.name());
+              logger.warn(
+                  "Thrift message will no longer be supported for data conversion in cadence-java-client V4, payload class name {}",
+                  instance.getClass().getName());
               return instance;
             } catch (Exception e) {
               throw new DataConverterException("Failed to deserialize TBase", e);

src/main/java/com/uber/cadence/converter/TEnumTypeAdapterFactory.java

@@ -26,6 +26,8 @@
 import java.io.IOException;
 import java.lang.reflect.Method;
 import org.apache.thrift.TEnum;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Special handling of TEnum serialization and deserialization. This is to support for inline TEnum
@@ -34,6 +36,8 @@
  */
 public class TEnumTypeAdapterFactory implements TypeAdapterFactory {
 
+  private static final Logger logger = LoggerFactory.getLogger(TEnumTypeAdapterFactory.class);
+
   @Override
   public <T> TypeAdapter<T> create(Gson gson, TypeToken<T> typeToken) {
     // this class only serializes 'TEnum' and its subtypes
@@ -44,6 +48,9 @@ public <T> TypeAdapter<T> create(Gson gson, TypeToken<T> typeToken) {
         new TypeAdapter<T>() {
           @Override
           public void write(JsonWriter jsonWriter, T value) throws IOException {
+            logger.warn(
+                "Thrift message will no longer be supported for data conversion in cadence-java-client V4, payload class name {}",
+                value.getClass().getName());
             jsonWriter.value(((TEnum) value).getValue());
           }
 
@@ -54,6 +61,9 @@ public T read(JsonReader jsonReader) throws IOException {
               Method m = (typeToken.getRawType().getDeclaredMethod("findByValue", Integer.TYPE));
               @SuppressWarnings("unchecked")
               T instance = (T) m.invoke(null, value);
+              logger.warn(
+                  "Thrift message will no longer be supported for data conversion in cadence-java-client V4, payload class name {}",
+                  instance.getClass().getName());
               return instance;
             } catch (Exception e) {
               throw new DataConverterException("Failed to deserilize TEnum", e);