Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data directory should be located in APPDATA on Windows #186

Open
klkq opened this issue May 19, 2022 · 3 comments
Open

Data directory should be located in APPDATA on Windows #186

klkq opened this issue May 19, 2022 · 3 comments
Labels
feature request Request for new feature or functionality

Comments

@klkq
Copy link

klkq commented May 19, 2022

What would you like to have changed?

On Windows, certmagic stores its data in %USERPROFILE%/.local/share by default at the moment, which should be located in %APPDATA% as Windows' convention.

Why is this feature a useful, necessary, and/or important addition to this project?

Following the operating system's convention gives users better understanding of the directory's function and eliminates unnecessary directory paths.

What alternatives are there, or what are you doing in the meantime to work around the lack of this feature?

Certmagic is used by Hysteria, which is considering

provide an option in "acme" for customizing the certificate storage directory.

Please link to any relevant issues, pull requests, or other discussions.

My issue in Hysteria repo

@klkq klkq added the feature request Request for new feature or functionality label May 19, 2022
@mholt
Copy link
Member

mholt commented May 19, 2022

That's probably a good idea. I'm not a Windows user; does the data just go into %APPDATA%? Or is there a subfolder, or how does that work?

@francislavoie
Copy link
Member

francislavoie commented May 19, 2022

In Caddy, the default is %AppData%\Caddy

https://caddyserver.com/docs/conventions#data-directory

I think the problem with simply changing the default is it might cause people to have all their certs reissued, unless they explicitly set the storage location otherwise. I think it would have to check both locations and move files over to the new location, if the old location still had files

@mholt
Copy link
Member

mholt commented May 19, 2022

Forgot about that 😅 Thanks

Yeah, the moving files thing is a good idea, but not always successful (if, for example, the two folders are on different drives). I will try, but maybe this is just better for the release notes (and give some instructions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for new feature or functionality
Projects
None yet
Development

No branches or pull requests

3 participants