Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accommodate Policy Changes in github.com/pires/go-proxyproto #6484

Closed
mohammed90 opened this issue Jul 28, 2024 · 3 comments · Fixed by #6485
Closed

Accommodate Policy Changes in github.com/pires/go-proxyproto #6484

mohammed90 opened this issue Jul 28, 2024 · 3 comments · Fixed by #6485
Labels
dependencies ⛓️ Pull requests that update a dependency file good first issue 🐤 Good for newcomers upstream ⬆️ Relates to some dependency of this project

Comments

@mohammed90
Copy link
Member

The go-proxyproto module has deprecated the Policy/PolicyFunc in favor of the ConnPolicy approach. To avoid breakage once they remove the field, we need to adapt to the change. It should be fairly simple and not breaking the users.
@mohammed90 mohammed90 added good first issue 🐤 Good for newcomers upstream ⬆️ Relates to some dependency of this project dependencies ⛓️ Pull requests that update a dependency file labels Jul 28, 2024
@pi-prakhar
Copy link
Contributor

@mohammed90

Can i take this one up?

@mohammed90
Copy link
Member Author

Sure, go for it.

@pi-prakhar pi-prakhar mentioned this issue Jul 29, 2024
Merged
@pi-prakhar
Copy link
Contributor

@mohammed90

i have created the pull request containing the necessary changes. #6485
So let me know if any improvements have to be made or if any additional changes are required.

As this is my first ever open source contribution.

@mohammed90 mohammed90 linked a pull request Aug 3, 2024 that will close this issue
proxyprotocol: Update WrapListener to use ConnPolicyFunc for PROXY protocol #6485
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies ⛓️ Pull requests that update a dependency file good first issue 🐤 Good for newcomers upstream ⬆️ Relates to some dependency of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proxyprotocol: Update WrapListener to use ConnPolicyFunc for PROXY protocol pi-prakhar/caddy
2 participants
@mohammed90 @pi-prakhar