-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[file_server browse] Layout setting is not saved #6386
Comments
Agreed. Can you suggest a good way to do that that doesn't require cookies? |
I don't know what is better, what's wrong with the cookie? |
Europe's laws make the use of cookies rather unbearable. |
Maybe local storage? |
Caddy is already using cookies, isn't it? |
The only time we set cookies, AFAIK, are when the user explicitly configures load balancing policy as such. The rest of those results are related to parsing existing cookie headers, not setting. |
Maybe, but that will be lost when sharing a link. You will be viewing a grid and someone else will see the list. |
I saw there is a cookie for the Sorting button which is very similar to the Layout button. |
Oh, interesting. I thought we got rid of those for query string parameters. In fact, I distinctly remember doing this... 🤔 We should probably remove those in favor of the query string. |
I think the cookie law is applied to similar types of cookie including localStorage. |
Just curious why don't you accept the law? Maybe add an opton for caddy's admin to show/not show the cookie banner? |
Cookie banners are destroying the Web. I think we can avoid it with query strings. But it might be a little more involved since it requires changing the links. |
When you change the file browser's layout between Grid/List, it's reset when you leave the current page/open other directory.
It would be better if the setting remains consistent until the user changes it.
The text was updated successfully, but these errors were encountered: