Skip to content

Commit 46ea82e

Browse files
committed
reverseproxy: clarify the reason for skipping an iteration
1 parent bb89648 commit 46ea82e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

modules/caddyhttp/reverseproxy/reverseproxy.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@ func (h *Handler) Provision(ctx caddy.Context) error {
131131

132132
// get validation out of the way
133133
for i, v := range h.Upstreams {
134-
// the special cases arise with LookupSRV present, so skip the iteration if it's empty.
134+
// Having LookupSRV non-empty conflicts with 2 other config parameters: active health checks, and upstream dial address.
135+
// Therefore if LookupSRV is empty, then there are no immediately apparent config conflict and the iteration can be skipped.
135136
if v.LookupSRV == "" {
136137
continue
137138
}

0 commit comments

Comments
 (0)