We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent bb89648 commit 46ea82eCopy full SHA for 46ea82e
modules/caddyhttp/reverseproxy/reverseproxy.go
@@ -131,7 +131,8 @@ func (h *Handler) Provision(ctx caddy.Context) error {
131
132
// get validation out of the way
133
for i, v := range h.Upstreams {
134
- // the special cases arise with LookupSRV present, so skip the iteration if it's empty.
+ // Having LookupSRV non-empty conflicts with 2 other config parameters: active health checks, and upstream dial address.
135
+ // Therefore if LookupSRV is empty, then there are no immediately apparent config conflict and the iteration can be skipped.
136
if v.LookupSRV == "" {
137
continue
138
}
0 commit comments