Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push even if the build fails #33

Closed
rtimush opened this issue Mar 13, 2020 · 7 comments
Closed

Push even if the build fails #33

rtimush opened this issue Mar 13, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@rtimush
Copy link

rtimush commented Mar 13, 2020

Until v4 the paths were pushed in parallel with the build, so the cache was populated even if the build would at the end fail. It seems that the current version updates the cache only if the build succeeds. This can be quite inconvenient for long builds.
What do you think about running the Cachix: Pushing paths group even if Invoking nix-build failed?

@domenkozar
Copy link
Member

Agreed, now that 0.3.7 is out I'll bring that back in.

@domenkozar domenkozar added the enhancement New feature or request label Mar 14, 2020
@domenkozar domenkozar self-assigned this Mar 23, 2020
@nomeata
Copy link
Contributor

nomeata commented Apr 6, 2020

I just came around to report this too. Especially in an early phase of a repository with dependencies that builds for an hour or more (think ghcjs) this would be very useful!

@domenkozar
Copy link
Member

Planning to do this one in a couple of days.

@nomeata
Copy link
Contributor

nomeata commented Apr 6, 2020

Thanks :)

@Mic92
Copy link
Contributor

Mic92 commented Apr 14, 2020

So does this still work in cachix-action-v4 or do I have to use cachix-action-v3?

@domenkozar
Copy link
Member

This is fixed on master, I'm testing if it also works when the build timeouts.

@domenkozar
Copy link
Member

Fixed via https://github.com/cachix/cachix-action/releases/tag/v6

WARNING: it's a breaking release, make sure to read changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants