Skip to content

Fix undefined reference to _caca_alloc2d #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix undefined reference to _caca_alloc2d #70

wants to merge 3 commits into from

Conversation

JohannesKauffmann
Copy link

  • Avoid implicit function declaration for _caca_alloc2d
  • Avoid nested extern declaration for _caca_alloc2d
  • Fix undefined reference to _caca_alloc2d

Fixes #59.

@JohannesKauffmann
common-image: avoid implicit function declaration
afacac2 
common-image.c: In function ‘load_image’:
common-image.c:164:18: warning: implicit declaration of function ‘_caca_alloc2d’ [-Wimplicit-function-declaration]
  164 |     im->pixels = _caca_alloc2d(im->w, im->h, depth);
      |                  ^~~~~~~~~~~~~
@JohannesKauffmann
caca: avoid nested externs
f57b0d6 
common-image.c:164:18: warning: nested extern declaration of ‘_caca_alloc2d’ [-Wnested-externs]
@JohannesKauffmann
caca_internals: export _caca_alloc2d
9683d1f 
It is used by the image viewer:

/usr/bin/ld: img2txt-common-image.o: in function `load_image':
../../src/common-image.c:164: undefined reference to `_caca_alloc2d'

Fixes cacalabs#59.
@hartwork hartwork mentioned this pull request Jan 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build 0.99.beta20 (common-image.c:164: undefined reference to `_caca_alloc2d')
1 participant
@JohannesKauffmann