Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow up fixes pagination PRs #10770

Open
2 of 6 tasks
inodb opened this issue Apr 26, 2024 · 3 comments · May be fixed by cBioPortal/cbioportal-frontend#4909
Open
2 of 6 tasks

follow up fixes pagination PRs #10770

inodb opened this issue Apr 26, 2024 · 3 comments · May be fixed by cBioPortal/cbioportal-frontend#4909
Assignees
@fuzhaoyuan
Labels
enhancement

Comments

@inodb
Copy link
Member

inodb commented Apr 26, 2024 •
edited
Loading

Related to cBioPortal/cbioportal-frontend#4786

  • after going to 500 and pressing show more the behavior is not super obvious. It keeps adding records it seems to how all 1-500? Not sure if this is intended

    image

    Disable 'show more' when this message appears

  • This banner only shows when using next page all the way to the last page. I assume it also needs to be displayed when you click 'Show more' until the maximum records.

- [ ] fix for multistudy queries, e.g. this example

  • Increase default 500 limit to be higher based on testing (should not take more than a second or so, maybe 5K?)
  • sorting of table is broken
    • It's only broken with Patient ID, Sample ID and Cancer Study columns
    • Here is a broken record
      image
@fuzhaoyuan
Copy link
Contributor

@inodb I discussed with Jeremy and he thinks it may be good to have:

  1. A parameter of the table to set different limit other than 500
  2. Somewhere around the table to inform user of the limit existance
    What do you think?

@inodb
Copy link
Member Author

inodb commented Apr 30, 2024

Thanks @fuzhaoyuan !

Based on yesterday's discussion, we can increase the default limit substantially beyond 500 based on how fast it responds (maybe 5K?). It's a bit slow getting all data here: https://www.cbioportal.org/study/clinicalData?id=msk_impact_2017. Added it to the checklist at the top

I think 1 & 2 makes sense but will require new UI. So I'd vote to first get this out in a way not/hardly noticeable to users and then have a follow-up PR that improves UI

@fuzhaoyuan
Copy link
Contributor

Do we want to make this banner ClinicalDataTab specific or keep if generic in the LazyMobXTable?

@fuzhaoyuan fuzhaoyuan linked a pull request May 9, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuzhaoyuan fuzhaoyuan

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clindata filter follow up fuzhaoyuan/cbioportal-frontend
2 participants
@inodb @fuzhaoyuan