Merge pull request #1609 from c9s/kbearXD/dca2/emit-position

FEATURE: emit position when position updated and reset

Author: kbearXD

pkg/strategy/dca2/state.go

@@ -215,6 +215,9 @@ func (s *Strategy) runTakeProfitReady(ctx context.Context, next State) {
 	// reset position and open new round for profit stats before position opening
 	s.Position.Reset()
 
+	// emit position
+	s.OrderExecutor.TradeCollector().EmitPositionUpdate(s.Position)
+
 	// store into redis
 	bbgo.Sync(ctx, s)
 

pkg/strategy/dca2/strategy.go

@@ -101,8 +101,7 @@ type Strategy struct {
 
 	// callbacks
 	common.StatusCallbacks
-	positionCallbacks []func(*types.Position)
-	profitCallbacks   []func(*ProfitStats)
+	profitCallbacks []func(*ProfitStats)
 }
 
 func (s *Strategy) ID() string {
@@ -280,6 +279,11 @@ func (s *Strategy) Run(ctx context.Context, _ bbgo.OrderExecutor, session *bbgo.
 			return
 		}
 
+		if s.takeProfitPrice.IsZero() {
+			s.logger.Warn("take profit price should not be 0 when there is at least one open-position order filled, please check it")
+			return
+		}
+
 		compRes := kline.Close.Compare(s.takeProfitPrice)
 		// price doesn't hit the take profit price
 		if compRes < 0 {