Skip to content

Commit 005bf23

Browse files
committed
dynamic: add one more test case
1 parent 75f1e72 commit 005bf23

File tree

1 file changed

+24
-10
lines changed

1 file changed

+24
-10
lines changed

pkg/dynamic/metric_test.go

+24-10
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,30 @@ func TestInitializeConfigMetrics(t *testing.T) {
2323
ignoredFieldInt int
2424
}
2525

26-
metricNames, err := initializeConfigMetricsWithFieldPrefix("test", "test-01", "", &Foo{
27-
MinMarginLevel: Number(1.4),
28-
Bar: &Bar{
29-
Enabled: true,
30-
},
26+
t.Run("general", func(t *testing.T) {
27+
metricNames, err := initializeConfigMetricsWithFieldPrefix("test", "test-01", "", &Foo{
28+
MinMarginLevel: Number(1.4),
29+
Bar: &Bar{
30+
Enabled: true,
31+
},
32+
})
33+
34+
if assert.NoError(t, err) {
35+
assert.Len(t, metricNames, 2)
36+
assert.Equal(t, "test_config_min_margin_level", metricNames[0])
37+
assert.Equal(t, "test_config_bar_enabled", metricNames[1], "nested struct field as a metric")
38+
}
39+
})
40+
41+
t.Run("nil struct field", func(t *testing.T) {
42+
metricNames, err := initializeConfigMetricsWithFieldPrefix("test", "test-01", "", &Foo{
43+
MinMarginLevel: Number(1.4),
44+
})
45+
46+
if assert.NoError(t, err) {
47+
assert.Len(t, metricNames, 1)
48+
assert.Equal(t, "test_config_min_margin_level", metricNames[0])
49+
}
3150
})
3251

33-
if assert.NoError(t, err) {
34-
assert.Len(t, metricNames, 2)
35-
assert.Equal(t, "test_config_min_margin_level", metricNames[0])
36-
assert.Equal(t, "test_config_bar_enabled", metricNames[1], "nested struct field as a metric")
37-
}
3852
}

0 commit comments

Comments
 (0)