Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to preserve symlinks #70

Closed
dhimmel opened this issue Feb 3, 2018 · 1 comment
Closed

Option to preserve symlinks #70

dhimmel opened this issue Feb 3, 2018 · 1 comment

Comments

@dhimmel
Copy link
Contributor

dhimmel commented Feb 3, 2018

Git supports symbolic links and symbolic links work with GitHub Pages (see example).

Currently, the default behavior of ghp-import is to follow symlinks for files but not directories. Specifying --follow-links causes ghp-import to follow links for both files and directories: see #37 (comment). However, neither case preserves the symlinks, which is a feature that would help me with manubot/rootstock#101.

Perhaps the ideal behavior (disregarding backwards compatibility) would be to:

  • preserve symlinks that link to a file or directory within the "documentation directory"
  • follow symlinks that link to a file or directory outside of the "documentation directory"

However, given backwards compatibility, it would make sense perhaps to have a --preserve-links argument that would preserve all symbolic links. It would be mutually exclusive with --follow-links.

@davisp what do you think? I could try to take a crack at an implementation. I haven't looked much into how difficult this would be to implement.

@c-w
Copy link
Owner

c-w commented Jul 25, 2020

@dhimmel Please submit a pull request for this. In the meantime, resolving this issue as it's over 2 years old. Feel free to reopen if it's still a blocker for you.

@c-w c-w closed this as completed Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants