Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

Commit 1ef2751

Browse files
committed
Add Note on go modules
1 parent 80e9913 commit 1ef2751

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

Diff for: .gitignore

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
.idea/
2-
*.log
2+
*.log
3+
go.sum

Diff for: README.md

+16
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,22 @@ echo "replace github.com/c-muéller/ads "(cat go.mod | grep 'github.com/c-muelle
5252

5353
After that just run `make` now CoreDNS should have complied with the version of the `ads` plugin you have currently checked out in the ads repository.
5454

55+
#### A note on `go modules`
56+
57+
To prevent version conflicts between CoreDNS and the ads plugin it is important to keep the
58+
`go.mod` file empty or if dependencies have been added that are not used by coreDNS only these should
59+
be added in the `go.mod` file on master.
60+
For reference the empty `go.mod` file looks like this:
61+
```
62+
module github.com/c-mueller/ads
63+
64+
go 1.12
65+
```
66+
67+
The go sum file should get deleted.
68+
69+
Because this strategy will make development annoying you can run `go mod tidy` to regenerate a proper `go,mod` file.
70+
5571
## Configuring
5672

5773
### Default settings

0 commit comments

Comments
 (0)