Skip to content

Commit ada6aa3

Browse files
kiwikZhuli
authored andcommitted
Use FAILURE to replace RETRY_LIMIT when compile error happen (apache#152)
Currently we execute make build in pre.yaml of k8s integration jobs to compile code, but if compile error happen, that cause job test result fall into RETRY_LIMIT status, that make some confusion, we should move make build into run.yaml to cause exact FAILURE status. Closes apache#151
1 parent 00347f9 commit ada6aa3

File tree

7 files changed

+19
-4
lines changed
  • playbooks
    • cloud-provider-openstack-acceptance-test-csi-cinder
    • cloud-provider-openstack-acceptance-test-e2e-conformance
    • cloud-provider-openstack-acceptance-test-k8s-cinder
    • cloud-provider-openstack-acceptance-test-keystone-authentication-authorization
    • cloud-provider-openstack-acceptance-test-lb-octavia
    • cloud-provider-openstack-acceptance-test-standalone-cinder
    • cloud-provider-openstack-acceptance-test

7 files changed

+19
-4
lines changed

playbooks/cloud-provider-openstack-acceptance-test-csi-cinder/run.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
set -e
1212
set -o pipefail
1313
14+
# Build cloud-provider-openstack binaries
15+
make build
16+
1417
# Create cloud-config
1518
mkdir -p /etc/kubernetes/
1619
cat << EOF >> /etc/kubernetes/cloud-config

playbooks/cloud-provider-openstack-acceptance-test-e2e-conformance/run.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
set -e
1111
set -o pipefail
1212
13+
# Build cloud-provider-openstack binaries
14+
make build
15+
1316
# Create cloud-config
1417
mkdir -p /etc/kubernetes/
1518
cat << EOF >> /etc/kubernetes/cloud-config

playbooks/cloud-provider-openstack-acceptance-test-k8s-cinder/run.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
set -e
1010
set -o pipefail
1111
12+
# Build cloud-provider-openstack binaries
13+
make build
14+
1215
# Create cloud-config
1316
mkdir -p /etc/kubernetes/
1417
cat << EOF >> /etc/kubernetes/cloud-config

playbooks/cloud-provider-openstack-acceptance-test-keystone-authentication-authorization/run.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
set -e
1212
set -o pipefail
1313
14+
# Build cloud-provider-openstack binaries
15+
make build
16+
1417
apt-get install python-pip -y
1518
pip install -U python-openstackclient
1619

playbooks/cloud-provider-openstack-acceptance-test-lb-octavia/run.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
set -e
1212
set -o pipefail
1313
14+
# Build cloud-provider-openstack binaries
15+
make build
16+
1417
apt-get install python-pip -y
1518
pip install -U python-openstackclient python-octaviaclient python-neutronclient
1619

playbooks/cloud-provider-openstack-acceptance-test-standalone-cinder/run.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
set -e
1414
set -o pipefail
1515
16+
# Build cloud-provider-openstack binaries
17+
make build
18+
1619
# Create cloud-config
1720
source /opt/stack/new/devstack/openrc admin admin
1821
mkdir -p /etc/kubernetes/

playbooks/cloud-provider-openstack-acceptance-test/pre.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
- name: build cloud-provider-openstack binary
1+
- name: Install dependencies
22
hosts: all
33
become: yes
44
roles:
@@ -12,9 +12,6 @@
1212
# Install dependencies
1313
go get -u github.com/Masterminds/glide
1414
15-
# Build cloud-provider-openstack binaries
16-
make build
17-
1815
executable: /bin/bash
1916
chdir: '{{ zuul.project.src_dir }}'
2017
environment: '{{ golang_env }}'

0 commit comments

Comments
 (0)