Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dquery update to use the new document global #16

Open
byteface opened this issue Aug 14, 2021 · 2 comments
Open

dquery update to use the new document global #16

byteface opened this issue Aug 14, 2021 · 2 comments

Comments

@byteface
Copy link
Owner

during d3 port we came up with the document global.

dQuery had employed an init method.

should I update dquery to use the new document global instead? think it makes sense.

@byteface
Copy link
Owner Author

byteface commented Nov 6, 2021

think i might have done this. untested. but i got it to return document in the prop if not set.

@byteface
Copy link
Owner Author

byteface commented Dec 4, 2021

problem with the document global is it exists purely for the sake of dquery and d3 not having to register a given dom. now window is starting to leverage it too. may leave this open for long term reconsideration on how to handle that. had lots of ideas. but also wasted time/branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant