Replies: 3 comments
-
Hey @byteface Long time dev, first time contributor. Hoping to help flesh out some tests/bugfix and learn about GitHub at the same time. I've forked the project & started working on tests for d3/Polygon.py and I found I had to write a function to parse the "points" attribute from a polygon as a 2D int array ('polygon.points' returns a string "x0,y0 x1,y1 ...") and modify the math functions to parse/use the points array. I want to make sure I'm on the right path before I'm in too deep, have I missed a way to get this attribute as a 2D array? |
Beta Was this translation helpful? Give feedback.
-
Hi @FrackOverflow Nice to hear from you. Very brave of you to join-in, esp on the math. hmmm. What you are saying rings a bell but it was a while since I looked at it. So I think there was something in d3 shape? https://github.com/d3/d3-shape/tree/main/src as I remember I wasn't going to commit polygon as it wasn't quite there and it might be for the reason you are saying. Something you're saying is vageuly familiar and not coming to me right this second. Sadly I accidently deleted a lot of stubbed out code to do with the d3 port and something may have been lost back when i did that. All that was left was these links to what they might be. https://github.com/byteface/domonic/blob/master/domonic/d3/__init__.py I think there is a method within d3. I remember when I was going over all the libs to see which ones would be doable but it would be gone from my mind now i think as it was a while ago. Also feel free to join on the discord... https://discord.gg/a9pSZv4V5f |
Beta Was this translation helpful? Give feedback.
-
note: pip install pytest to get coverage as the tests run. Then do... pytest tests This is useful as shows various deprecation and other issues. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
All reactions