Addition of libpostal preset #502
Conversation
|
Thanks! Please also add to |
|
Thanks! Could you also add entries for unsupported platforms to make sure empty artifacts get created? |
|
Yeah, unfortunately Maven, etc require empty artifacts for unsupported platforms, or users have to exclude them manually. |
|
Now the unsupported platform builds are failing because of the missing libpostal header file that JavaCPP is expecting. How to solve this? |
|
List only the supported platforms in the |
|
Keep your fingers crossed, and i wish you a happy and healthy new year :) |
|
Since libpostal is written in c and the header file declares |
|
It doesn't look like it, but it's usually preferable yes. |
…iven components if there are other ignorable components
|
g++ has no cpp 11 for Linux x86_64? LLVM seems to have it, what am i missing/overseeing? |
|
Samuel, i see you have removed the need for empty artefacts. If the builds run fine now I will commit the resolved conflicts. |
|
Yes, please do. Sorry for the breaking changes, but you had me started thinking about this and it clicked so I made the changes. :) And while you're at it, version "1.1-alpha" was just released, so let's use that for the presets: https://github.com/openvenues/libpostal/releases As for C++11 support with GCC or Clang, we need to pass them an option, and we can do that with a |
|
I just removed the cpp 11 directive because the linux build failed on travis because of it and i cannot trace why. I will try the alpha version locally, yesterday morning the build was breaking untill the latest commits of albarrentine. |
|
Having following issues with v1.1-alpha executing JavaCPP: [INFO] --- javacpp:1.3.4-SNAPSHOT:build (javacpp.compiler) @ libpostal --- jnilibpostal.cpp /out:jnilibpostal.dll |
|
Indeed, so you say configure this in the preset? |
|
What do you mean? Don't write link="libpostal".
|
|
Yes, it is ether |
|
Why can't we do exactly like libdc1394? |
|
Analog to libdc1394 where |
|
Some modules other then libpostal are breaking, as far as i can see by missing dependencies / timeouts. Is it possible to restart these individually? |
|
Yes, but it's not related to libpostal, so don't worry about them. One thing we'll need to fix though is that |
|
Also you forgot to include the version of the link library. It'll probably fail to load on Linux and Mac because of that. We'll need something similar to libdc1394, and I'm guessing |
|
Potverdorie, i need to delete my local Maven repo before builing and testing... |
|
No you don't need to do that, but you do need to clean up the |
Corrected formatting in the pom and CI/CD markup, corrected ordering of libpostal after llvm and before mkl if llvm is not available for specific a platform. Tested after cleaning and deleting the.javacpp folder.
|
You'll probably need to add an |
|
Well, i tested libpostal on all 3 platforms without problems so i thought we might not need the |
|
I just tested all three platforms again, doing a maven clean on the preset and the platform, deleting the maven vectors in my local repo and deleting the .javacpp cache folders. They where all functional without errors. Is the addition of a patch with |
|
Maybe not...
|
|
It looks like they keep updating |
|
I tested the lib on Centos 7, Windows 10 and MacOS High Sierra, all 64 bit arch, successfully. |
|
But you didn't remove the |
|
...a Maven clean was included with the build, deleting the project files, I will try the 1.1 version as well. |
|
You change the mac configuration on the fly with |
|
Got it, the binary can search the dynamic library through a relative path allowing it to run everywhere: On the Mac a dynamic library (dylib) has an "install name". The install name is a path baked into the dynamic library that says where to find the library at runtime. When you link against the dylib this path is saved in your binary so that your binary can find the dylib at runtime. Since run paths is rather new to macos and is a standard linux feature, why do we not have to configure this for the linux build as well? Or does JavaCPP anticipate on this? |
|
We don't need it on Linux. It does what |
|
Still a lot to learn in native land, thanks for your patience. I have put up a blog post mentioning the JavaCPP project and your name if that is OK with you. |
|
Yes of course, please do! And thanks for the contribution! |
Requesting addition of the libpostal preset for Windows, Linux and MacOS 64bit.
libpostal is a C library for parsing/normalizing street addresses around the world using statistical NLP and open data. The goal of this project is to understand location-based strings in every language, everywhere.