Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic while calling Error() #700

Closed
Termina1 opened this issue Oct 11, 2024 · 4 comments
Closed

panic while calling Error() #700

Termina1 opened this issue Oct 11, 2024 · 4 comments

Comments

@Termina1
Copy link

Found degradation in version v1.12.1, occurs when I'm trying to deserialise value that is number into string.

goroutine 9078663823 [running]:
github.com/bytedance/sonic/internal/decoder/errors.swithchJSONType(...)
	/go/pkg/mod/github.com/bytedance/[email protected]/internal/decoder/errors/errors.go:145
github.com/bytedance/sonic/internal/decoder/errors.MismatchTypeError.Error({0x3, {0xc038c962d8, 0x3}, {0x2fb2530, 0x2057200}})
	/go/pkg/mod/github.com/bytedance/[email protected]/internal/decoder/errors/errors.go:162 +0x24e
@liuq19 liuq19 changed the title panic while calling Error() panic while calling Error(), pls update version into v1.12.2 Oct 11, 2024
@liuq19 liuq19 changed the title panic while calling Error(), pls update version into v1.12.2 [Solved] panic while calling Error(), pls update version into v1.12.2 Oct 11, 2024
@Termina1
Copy link
Author

Termina1 commented Oct 11, 2024 •
edited
Loading

This reproduces on the latest version of sonic. Its not solved.

@liuq19 liuq19 changed the title [Solved] panic while calling Error(), pls update version into v1.12.2 panic while calling Error() Oct 11, 2024
@liuq19
Copy link
Collaborator

liuq19 commented Oct 11, 2024

Are there any reproducible examples, with a complete panic stack and go env?

@liuq19
Copy link
Collaborator

liuq19 commented Oct 15, 2024

any updates? @Termina1

@liuq19
Copy link
Collaborator

liuq19 commented Dec 2, 2024 •
edited
Loading

@Termina1 Maybe fixed by #717

@AsterDY AsterDY closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Termina1 @liuq19 @AsterDY